Initial OpenACC port of mpas_atm_update_bdy_tend #1301
Conversation
|
Thanks for the review! I'll address the comments, but just wanted to note that this PR may not be a priority for merging to |
Combining some OpenACC loops and parallel regions. Some whitespace changes. Removing redundant calls to mpas_pool_get_array.
abishekg7
force-pushed
the
atmosphere/port_mpas_atm_update_bdy_tend
branch
from
8bc1e96 to
057ee7e
Compare
|
Addressed the review comments. I did have to rebase with the latest |
| rho_zz(:,:) = rho(:,:) / zz(:,:) | ||
| !$acc end kernels | ||
|
|
||
| !$acc parallel |
There was a problem hiding this comment.
Should we add default(present) to this parallel directive (and also to others below)?
There was a problem hiding this comment.
Thanks! Done and I've also converted the kernels statement to a parallel region, as it is not a temporary loop. Combining these parallel regions is a little tricky, so I've left them separate as it was.
Converting acc kernels to an acc parallel region, following earlier discussions to only use kernels directive for temporary code regions. Using the default(present) clauses for parallel regions to be consistent with the rest of the code.
Initial OpenACC port of
mpas_atm_update_bdy_tend.This port is required to keep
stateandtendvariables from LBCs eventually resident on GPUs.